Conversation
jorgeazevedo
added
the
maintenance
Contributor
jorgeazevedo
force-pushed
the
ja-use-standard-sbt
branch
3 times, most recently
from
5378656 to
6328e32
Compare
Remove the custom ./sbt script that bundled sbt-launch.jar and replace it with the standard sbt command. JVM memory options are now configured in .jvmopts, and the local dev config file is set via build.sbt (run / javaOptions). This aligns with modern sbt best practices where sbt is installed on the machine and fetches the right version from project/build.properties.
jorgeazevedo
force-pushed
the
ja-use-standard-sbt
branch
from
6328e32 to
00de658
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Replace the custom
./sbtwrapper script (which bundledsbt-launch.jar) with the standardsbtcommand, moving JVM options to.jvmoptsand the local dev config tobuild.sbt.How has this change been tested?
Have we considered potential risks?